Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: Action redesign #19882

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

storage: Action redesign #19882

wants to merge 12 commits into from

Commits on Apr 5, 2024

  1. storage: Move all actions into the menu, except primary ones 

    And make "Mount" and "Create new logical volume" primary actions.
    @mvollmer
    mvollmer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    89390e6 View commit details
    Browse the repository at this point in the history

  2. storage: Move "Format" action one card up 

    Offer it on the "Partition" card instead of the "Filesystem" card, for
example.

This makes more sense. One formats a partition, but mounts the
filesystem.
    @mvollmer
    mvollmer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c2ab4ae View commit details
    Browse the repository at this point in the history

  3. storage: Move "Lock" and "Unlock" actions to "Encryption" card 

    That's where they belong. Filesystems are still automatically locked
and unlocked when mounting and unmounting them.
    @mvollmer
    mvollmer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    7985233 View commit details
    Browse the repository at this point in the history

  4. storage: Remove "Unrmatted Data" and "Locked Data" cards 

    They have no actions anymore.
    @mvollmer
    mvollmer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    5d6f76b View commit details
    Browse the repository at this point in the history

  5. storage: New "Add encryption" action for unformatted blocks

    @mvollmer
    mvollmer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    d83096d View commit details
    Browse the repository at this point in the history

  6. storage: Offer "Format" on "Encryption" card

    @mvollmer
    mvollmer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    56c949a View commit details
    Browse the repository at this point in the history

  7. storage: Remove "Reuse existing encryption" option

    @mvollmer
    mvollmer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    bcf8bb1 View commit details
    Browse the repository at this point in the history

  8. storage: Split "Erase" out from "Format" dialogs 

    This allows us to make the format dialogs non-dangerous and primary,
and give them more descriptive names.

The "Create partition" version of the "Format" dialog now defaults to
"empty", and "empty" can not be encrypted. This makes it a very simple
dialog.
    @mvollmer
    mvollmer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    f5f7de4 View commit details
    Browse the repository at this point in the history

  9. storage: Offer global "Create partition" action

    @mvollmer
    mvollmer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    87d73db View commit details
    Browse the repository at this point in the history

  10. storage: Move swap creation out of filesystem format dialog

    @mvollmer
    mvollmer committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    21ded11 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. storage: Remove "Overwrite" option in Erase dialog 

    It's not a secure erase by any means.
    @mvollmer
    mvollmer committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2e613ab View commit details
    Browse the repository at this point in the history

  2. storage: Simplify "Initialize disk" dialog 

    Use radio buttons, and only offer MBR when it will work.
    @mvollmer
    mvollmer committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c5c38a9 View commit details
    Browse the repository at this point in the history