test: Enable kdump on Fedora 39 #19524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Ah yes, this check can't work on the current fedora-39 image, as the service does run by default. But I'd rather confirm this behaviour and land this PR in lockstep with the image refresh than relaxing the check. |
martinpitt
force-pushed
the
enable-kdump
branch
from
6271893
to
a08095b
Compare
https://bodhi.fedoraproject.org/updates/FEDORA-2023-93fab3be92 disables the kdump/crashkernel configuration by default, so we need to go back to explicitly enabling it on Fedora 39 as well. Unify this process on all Fedora versions, and use `kdumpctl` instead of messing around with `grubby`.
martinpitt
force-pushed
the
enable-kdump
branch
from
a08095b
to
ad553ed
Compare
jelly
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-93fab3be92 disables the kdump/crashkernel configuration by default, so we need to go back to explicitly enabling it on Fedora 39 as well.
Unify this process on all Fedora versions, and use
kdumpctlinstead of messing around withgrubby.This blocks cockpit-project/bots#5442 . I'm triggering an extra fedora-39/expensive@bots#5442 test run against that image. This PR needs to land in lockstep with the image refresh.