Clear button in searchInput

[Abdelra6]

closes #236

replicate of #240 closed it by accident because of some conflicts

[Abdelra6]

@garrett the width of the input is fixed now. I changed the components. I hope that's a better one)

[garrett]

Oh, we usually re-use the same PR for the same branch so the conversation isn't fragmented and gets lost. That's done with a force push, such as git push --force-with-lease and the branch info (this version checks to make sure your local branch is up to date with the server).

Two problems:

1. The X icon is always there now, even when nothing was typed.
2. When clicking the X to clear the entry, I get an "Ooops!" error.

My dev console says:

Uncaught TypeError: setCurrentFilter is not a function
    onClick header.jsx:62
    React 15
        callCallback2
        invokeGuardedCallbackDev
        invokeGuardedCallback
        invokeGuardedCallbackAndCatchFirstError
        executeDispatch
        processDispatchQueueItemsInOrder
        processDispatchQueue
        dispatchEventsForPlugins
        dispatchEventForPluginEventSystem
        batchedUpdates$1
        batchedUpdates
        dispatchEventForPluginEventSystem
        dispatchEventWithEnableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay
        dispatchEvent
        dispatchDiscreteEvent

[garrett]

(See above; I forgot to make it a review instead of a normal comment.)

[Abdelra6]

Sorry I can't test it completely due to the fsinfo commit. How can I make the [x] button appear without changing the width of the input?

[jelly]

_ is already bound to cockpit.gettext. Just pass setCurrentFilter("").

[jelly]

This needs to be behind some conditional like currentFilter !== ""

[Abdelra6]

Yes but that also will increase the width

[jelly]

Superseeded by #465