Add basic text editor using textarea

[MahmoudHamdy02]

• Fix context menu:
  Context menu breaks after closing the editor, either after 'save' or 'cancel'. After changing directory it works normally until the page is refreshed
• Add tests

[jelly]

I am not sure if this is the right UX pattern as we don't have an example of an editor anywhere in Cockpit, but it might be worth it to add a beforeunload event so when a user accidently closes the tab they get a warning. @garrett

[garrett]

I am not sure if this is the right UX pattern as we don't have an example of an editor anywhere in Cockpit, but it might be worth it to add a beforeunload event so when a user accidently closes the tab they get a warning. @garrett

Yes, set this in an onChange event (so it will only block when the content has changed) and make sure it's unset when the modal is dismissed with an action (save, cancel).

In other words, if nothing has changed in the textarea (or if it was saved or discarded), then it shouldn't block closing the page. But if something was changed, then block the page.

[KKoukiou]

thanks - I like it much more.

[MahmoudHamdy02]

Using cockpit.file().replace() with empty text will delete the file. We can use truncate -s 0 until the bug is fixed in the bridge.

[garrett]

I tried this branch, but the directory and files area is blank for me. (It's fine in main.)

[garrett]

To make it clear what I was thinking about, I've included a design @ #63:

I remember some discussion about this somewhere, but can't find it.

There were issues with the PatternFly code editor widget. I don't know of all the details. But the most basic first pass would be something like this:

It uses a basic textarea (HTML, but probably PatternFly's wrapper to the HTML element). It is a modal so you don't lose your place in the file browsing and can edit one file after another. On the left is editing mode; on the right is view-only / read-only.

First pass could be read-only viewing. Second pass could be editing. Third pass could be some kind of code viewer enhancement. However, the goal should be quick and easy simple editing of plain text files only, not a full-blown IDE (or even a full text editor like vim or emacs), so stopping at pass 2 (editable text area), at least for a while, is fine.

[garrett]

We'd want to make the size as large as possible vertically; there should be a little bit of space around it, but most of it should be editing. Otherwise, it's going to be annoying to use. For example:

[mac2net]

I wouldn't over-engineer this.
It's better to ship something and get feedback.
People can still also use the 45drives one in the meantime.