Add duplicate item button #105
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahmoudHamdy02
force-pushed
the
duplicate-item
branch
2 times, most recently
from
a82b71f
to
35b12bb
Compare
MahmoudHamdy02
force-pushed
the
duplicate-item
branch
from
35b12bb
to
4159275
Compare
KKoukiou
requested changes
Sep 4, 2023
| @@ -210,6 +214,7 @@ export const Application = () => { | |||
| { title: _("Edit properties"), onClick: _editProperties }, | |||
| { title: cockpit.format(_("Rename $0"), selectedContext?.type), onClick: _renameItem }, | |||
| { type: "divider" }, | |||
| { title: cockpit.format(_("Duplicate $0"), selectedContext?.type), onClick: _duplicateItem }, | |||
There was a problem hiding this comment.
I would use the 'Copy to...' label that the nautilus is using and allow the user to select the target directory.
There was a problem hiding this comment.
So this should use the FileAutoComplete component (like in creating link)? Because it shows all files, while we want directories only
There was a problem hiding this comment.
True, I think the FileAutocomplete component would need extension to support showing only specific type (file vs directory)
There was a problem hiding this comment.
but for now it should be fine to introduce this with a plain text input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99
Errors need to be shown somewhere in the page