Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce file viewer for plaintext files #63

Open
KKoukiou opened this issue Jul 13, 2023 · 2 comments · May be fixed by #83
Open

Introduce file viewer for plaintext files #63

KKoukiou opened this issue Jul 13, 2023 · 2 comments · May be fixed by #83

Comments

@KKoukiou
Copy link
Collaborator

Introduce a file viewer for code files (like plaintext, but with syntax highlighting)

Bonus item: (can be split into new issue if hard) edit text files?
Use https://www.patternfly.org/v4/components/code-editor

@KKoukiou KKoukiou added this to the 2023.09 milestone Aug 24, 2023
@KKoukiou KKoukiou linked a pull request Sep 4, 2023 that will close this issue
@KKoukiou KKoukiou removed this from the 2023.09 milestone Nov 15, 2023
@ashutosh7i
Copy link

hello @KKoukiou ,
is this still open?

i would like to work on it and add a code/text preview thing as i am comfortable with patternfly and worked with it before.

@garrett
Copy link
Member

garrett commented Apr 9, 2024

I remember some discussion about this somewhere, but can't find it.

There were issues with the PatternFly code editor widget. I don't know of all the details. But the most basic first pass would be something like this:

image

It uses a basic textarea (HTML, but probably PatternFly's wrapper to the HTML element). It is a modal so you don't lose your place in the file browsing and can edit one file after another. On the left is editing mode; on the right is view-only / read-only.

First pass could be read-only viewing. Second pass could be editing. Third pass could be some kind of code viewer enhancement. However, the goal should be quick and easy simple editing of plain text files only, not a full-blown IDE (or even a full text editor like vim or emacs), so stopping at pass 2 (editable text area), at least for a while, is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants