-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce file viewer for plaintext files #63
Comments
hello @KKoukiou , i would like to work on it and add a code/text preview thing as i am comfortable with patternfly and worked with it before. |
I remember some discussion about this somewhere, but can't find it. There were issues with the PatternFly code editor widget. I don't know of all the details. But the most basic first pass would be something like this: It uses a basic textarea (HTML, but probably PatternFly's wrapper to the HTML element). It is a modal so you don't lose your place in the file browsing and can edit one file after another. On the left is editing mode; on the right is view-only / read-only. First pass could be read-only viewing. Second pass could be editing. Third pass could be some kind of code viewer enhancement. However, the goal should be quick and easy simple editing of plain text files only, not a full-blown IDE (or even a full text editor like vim or emacs), so stopping at pass 2 (editable text area), at least for a while, is fine. |
Introduce a file viewer for code files (like plaintext, but with syntax highlighting)
Bonus item: (can be split into new issue if hard) edit text files?
Use https://www.patternfly.org/v4/components/code-editor
The text was updated successfully, but these errors were encountered: