Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When filtering returns no results show that to the user #236

Closed
jelly opened this issue Feb 1, 2024 · 1 comment
Closed

When filtering returns no results show that to the user #236

jelly opened this issue Feb 1, 2024 · 1 comment
Labels
bug Something isn't working
Milestone
First official re...

Comments

@jelly
Copy link
Member

jelly commented Feb 1, 2024

image

Add EmptyState which shows No files or directories found.

As a bonus add a cross button which removes the current filter as in the hosts selector:

image
@jelly jelly added the bug Something isn't working label Feb 1, 2024
@jelly
Copy link
Member Author

jelly commented Feb 1, 2024 •
edited

Or:

image

PatternFly component we want to use https://www.patternfly.org/components/text-input-group#utilities-and-icon

This was referenced Feb 2, 2024
Closed
Closed
@jelly jelly added this to the First official release milestone Apr 9, 2024
jelly added a commit to jelly/cockpit-navigator that referenced this issue May 22, 2024
@jelly
Add a button to clear the search input
98ef28d 
Use PatternFly's `onClear` handler to dynamically show a button to clear
the search input.

Closes: cockpit-project#236
jelly added a commit to jelly/cockpit-navigator that referenced this issue May 23, 2024
@jelly
Add a button to clear the search input
216acca 
Use PatternFly's `onClear` handler to dynamically show a button to clear
the search input.

Closes: cockpit-project#236
jelly added a commit to jelly/cockpit-navigator that referenced this issue May 28, 2024
@jelly
Add a button to clear the search input
f871e92 
Use PatternFly's `onClear` handler to dynamically show a button to clear
the search input.

Closes: cockpit-project#236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
First official release
1 participant
@jelly