Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use account-map component for brownfield env #945

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nitrocode
Copy link
Member

what

  • feat: use account-map component for brownfield env

why

  • Allow brownfield environments to use the account-map component with existing accounts

references

Signed-off-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@nitrocode nitrocode requested review from a team as code owners January 6, 2024 04:45
Comment on lines +9 to +11
non_suspended_account_ids = [for k, v in data.aws_organizations_organization.organization.accounts : v.id if v.status != "SUSPENDED"]

full_account_map = { for k, v in module.accounts.outputs.account_info_map : k => v.id if contains(local.non_suspended_account_ids, v.id) }
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the advantage of this change?

Note that this is unacceptable in any case because it removes the renaming of the root account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants