Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqs-queue better support dead-letter queues #1037

Merged
merged 2 commits into from
May 16, 2024
Merged

sqs-queue better support dead-letter queues #1037

merged 2 commits into from
May 16, 2024

Conversation

Benbentwo
Copy link
Member

what

  • Updates component sqs-queue to better support dead-letter queues

why

  • This is an awkward component currently, it is really just a pass through to an sqs resource. This should probably be broken down into a module and then wrapped with a component. In the meantime, this will allow easier access to other sqs-queues' URL for the redrive policy which is used for deadletter queues

references

@Benbentwo Benbentwo requested review from a team as code owners May 15, 2024 19:55
modules/sqs-queue/variables.tf Outdated Show resolved Hide resolved
modules/sqs-queue/remote-state.tf Show resolved Hide resolved
modules/sqs-queue/main.tf Outdated Show resolved Hide resolved
modules/sqs-queue/main.tf Outdated Show resolved Hide resolved
@Benbentwo Benbentwo merged commit fe8544c into main May 16, 2024
193 of 258 checks passed
@Benbentwo Benbentwo deleted the dead-letter branch May 16, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants