Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vpc): add named subnets #1032

Merged
merged 6 commits into from
May 20, 2024
Merged

feat(vpc): add named subnets #1032

merged 6 commits into from
May 20, 2024

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented May 11, 2024 •
edited

what

  • add named subnets to vpc component

why

  • allow using named subnets for databases

references

@nitrocode nitrocode requested review from a team as code owners May 11, 2024 20:49
aknysh
aknysh reviewed May 11, 2024
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitrocode thank you, please format TF code

@nitrocode
fix: terraform fmt
36deafa 
Signed-off-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@nitrocode nitrocode requested a review from aknysh May 12, 2024 16:39
@nitrocode
Copy link
Member Author

@milldr @aknysh thank you for fixing tests.

Is there anything left to do before this can be merged?

@milldr
Copy link
Sponsor Member

milldr commented May 20, 2024

Is there anything left to do before this can be merged?

Nope this looks good to me. I'll merge

@milldr milldr merged commit 68b1262 into cloudposse:main May 20, 2024
5 checks passed
@nitrocode nitrocode deleted the vpc-subnet-names branch May 23, 2024 04:48
@nitrocode
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milldr milldr milldr approved these changes

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nitrocode @milldr @aknysh