Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support guardduty protection features #1018

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

RoseSecurity
Copy link
Member

@RoseSecurity RoseSecurity commented Apr 14, 2024

Why

  • Upgrades the GuardDuty component to support processing a stream of events (VPC flow logs, DNS logs, AWS CloudTrail, etc.) before analyzing these events to identify potential security threats and generate findings. Historically, GuardDuty protections were called dataSources in the APIs. However, after March 2023, new GuardDuty protection types are now configured as features and not dataSources.

What

  • This PR directly adds support for RDS login monitoring, but the component can now configure GuardDuty detection features such as S3 data events, EKS audit logs, RDS login events, EKS runtime monitoring, Lambda network, logs, and EC2 runtime monitoring.

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • This change requires a documentation update

Usage

components:
  terraform:
    guardduty/defaults:
      metadata:
        component: compliance/guardduty
        type: abstract
      vars:
        detector_features:
          rds_protection:
            feature_name: "RDS_LOGIN_EVENTS"
            status: "ENABLED"

Testing

  • Notable comments:

    • Deleting this resource does not disable the detector feature, the resource in simply removed from state instead
    • Specifying both EKS Runtime Monitoring (EKS_RUNTIME_MONITORING) and Runtime Monitoring (RUNTIME_MONITORING) will cause an error. You can add only one of these two features because Runtime Monitoring already includes the threat detection for Amazon EKS resources
  • Validated with atmos validate stacks

  • Performed successful atmos terraform plan on component

References

@RoseSecurity RoseSecurity requested review from a team as code owners April 14, 2024 15:01
@RoseSecurity RoseSecurity changed the title Support GuardDuty Protection Features feat: support guardDuty protection features Apr 17, 2024
@RoseSecurity RoseSecurity changed the title feat: support guardDuty protection features feat: support guardduty protection features Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant