Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account-map bugfix #1012

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

account-map bugfix #1012

wants to merge 3 commits into from

Conversation

Benbentwo
Copy link
Member

what

  • Bugfix for Account-map: Do not check empty Stack definitions

why

Currently, account-map reads all stacks and looks for aws-team-roles and aws-teams components. This currently works when all stacks are defined. We often deploy many stacks that do not have team roles, specifically when deploying our compliance suite.

example command:

atmos describe stacks --components=aws-teams --component-types=terraform --sections=vars

sample Output:

core-euw3-security: {}
core-gbl-identity:
  components:
    terraform:
      aws-teams:
        vars:
          descriptor_formats: ...
core-sae1-artifacts: {}
core-sae1-audit: {}
core-sae1-auto: {}

references

@Benbentwo Benbentwo requested review from a team as code owners April 3, 2024 19:34
@Benbentwo Benbentwo added the do not merge Do not merge this PR, doing so would cause problems label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge this PR, doing so would cause problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant