Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add org compliance packs to aws-config #1006

Merged
merged 12 commits into from
May 25, 2024
Merged

feat: add org compliance packs to aws-config #1006

merged 12 commits into from
May 25, 2024

Conversation

dudymas
Copy link
Contributor

@dudymas dudymas commented Mar 25, 2024

what

  • new module in aws-config for org scoped conformance packs

why

  • allows conformance packs to automatically be applied to accounts in the org

@dudymas dudymas requested review from a team as code owners March 25, 2024 19:45
mcalhoun
mcalhoun previously requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a different approach

modules/aws-config/main.tf Outdated Show resolved Hide resolved
modules/aws-config/modules/org-conformance-pack/README.md Outdated Show resolved Hide resolved
@dudymas dudymas force-pushed the feat/compliance/add-org-aws-config branch from 0ffaccb to 5bc459b Compare April 18, 2024 18:58
@dudymas dudymas dismissed mcalhoun’s stale review April 18, 2024 19:21

Changes have been made to PR

mcalhoun
mcalhoun previously approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dudymas dudymas requested a review from osterman May 10, 2024 22:30
@dudymas dudymas requested a review from mcalhoun May 24, 2024 13:57
@dudymas dudymas merged commit af287c1 into main May 25, 2024
5 checks passed
@dudymas dudymas deleted the feat/compliance/add-org-aws-config branch May 25, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcaven arcaven arcaven left review comments

@github-actions github-actions[bot] github-actions left review comments

@osterman osterman osterman approved these changes

@mcalhoun mcalhoun Awaiting requested review from mcalhoun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dudymas @osterman @mcalhoun @arcaven @aknysh