-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Network Manager Resource w/ Core & Global #9514
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also implement mark-for-op and marked-for-op as part of tagging functionality.
config_type = None | ||
cfn_type = 'AWS::NetworkManager::CoreNetwork' | ||
permissions_augment = ("networkmanager:ListTagsForResource",) | ||
universal_taggable = object() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this line since 'tag' and 'untag' are implemented.
date = 'CreatedAt' | ||
config_type = cfn_type = 'AWS::NetworkManager::GlobalNetwork' | ||
permissions_augment = ("networkmanager:ListTagsForResource",) | ||
universal_taggable = object() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this line since 'tag' and 'untag' are implemented.
permissions_augment = ("networkmanager:ListTagsForResource",) | ||
universal_taggable = object() | ||
|
||
source_mapping = {'describe': DescribeGlobalNetwork, 'config': ConfigSource} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this line since it doesn't provide any additional functionality.
Adds support for AWS Network Manager resource. Including Core Network and Global Network.
Closes #9511 #9512 & #9513
GlobalNetwork
Core Network