Filter out None elasticbeanstalk envs

[dmytro-afanasiev]

describe_environments returns terminated environments (at least those that were terminated recently) but list_tags_for_resource raises ResourceNotFoundException if we try it with terminated environment.

Image

So, if i try to execute the policy below over my two terminated envs,

policies:
  - name: example-policy
    resource: aws.elasticbeanstalk-environment

i'll get such a result (example-policy/resources.json):

[
  null,
  null
]

It happens because _eb_env_tags returns None in case it cannot fetch tags for an environment. I'm not sure about the fix. Maybe we should just keep the environment without fetched tags, i.e return eb_env without changes if ResourceNotFoundException?

[kapilt]

It feels like the fix is two fold, handle better on not getting tags, but also default to listing active/pending environments.

[dmytro-afanasiev]

It feels like the fix is two fold, handle better on not getting tags, but also default to listing active/pending environments.

Rewrote to return just empty tags

[ajkerrigan]

Thanks, looks good 👍 .

To @kapilt 's point I could see it being useful to default to IncludedDeleted=False and allow query overrides... but that feels like an enhancement while this is a more targeted fix.