Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure - filter - use retry #9363

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

iamanmolm
Copy link

This fixes issue reported in #9346

@iamanmolm iamanmolm requested a review from kapilt as a code owner March 19, 2024 04:19
Copy link

linux-foundation-easycla bot commented Mar 19, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@@ -25,6 +25,7 @@

from c7n import config
from c7n.exceptions import ClientError, PolicyValidationError
from azure.core.exceptions import HttpResponseError
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should go into c7n_azure utils, rather then creating a hard dependency on azure for the base package. Also note there is separate retry handling there custodian_send_azure_override as an example that tries to incorporate this into the base client.

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azure specific retry logic should be in the c7n_azure package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants