Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed RelationalDB to DatabaseEngine #1236

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cloutiertyler
Copy link
Contributor

Description of Changes

This renames RelationalDB to DatabaseEngine. No other changes are made.

Expected complexity level and risk

1.5

Testing

I have done no additional testing.

@Centril
Copy link
Contributor

Centril commented May 15, 2024

If you don't mind, I would prefer if we wait to merge this until after #1166 and friends as it touches some of the same paths.

@cloutiertyler
Copy link
Contributor Author

Sure, yeah, that's fine, this is just a mechanical change, so it's not urgent at all.

@bfops bfops added release-any To be landed in any release window breaks library compatibility This change breaks the SpacetimeDB library interface labels May 21, 2024
Copy link
Contributor

@kim kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name change is 👍

Small nit: it could be a bit more pleasant on the eye to name the module just engine and/or re-export DatabaseEngine such that core::db::DatabaseEngine.

@cloutiertyler
Copy link
Contributor Author

Yeah I agree with that. I will update it to be db::engine::DatabaseEngine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward-compatible breaks library compatibility This change breaks the SpacetimeDB library interface release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants