Refactor add quick check before import tensorflow #1076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[ ✏️ Write your summary here. ]
When the function
assert_valid_inputs
is called we default to import tensorflow to check if the provided data is a tensorflow dataset. However the first tensorflow import is slow and we could quickly check for other common inputs first. By adding this quick check we can skip the tensorflow import unless it is likely that the provided data is a tensorflow dataset. The performance impact of this check is ~40ns in my laptop when the data is actually a tensorflow dataset and it is about the same performance improvement when X is None / numpy / pandas / list and tensorflow was already imported before.Impact
Testing
References
Reviewer Notes