Add Plane-Wave Storm #601
Closed
Add Plane-Wave Storm #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a couple of miscellaneous bugs
|
I am going to drop this as I think it is a bit too niche and can mostly be accomplished via a synthetic storm. Miscellaneous improvements that were part of this PR that are relevant have been added to #616. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new model storm type that is simply a pressure core of a Holland '80 storm but a plane-wave, i.e. it extends in the y-direction. This is useful for testing purposes and so was decided to leave it in for such things. Future parameters could include an angle for the symmetry or at least direction so that symmetry can be placed in the x-direction as well.