-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Owi integration #531
Open
cjeffr
wants to merge
74
commits into
clawpack:master
Choose a base branch
from
cjeffr:OWI_integration
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Owi integration #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent index based on time step
…u and v wind directions to storm object
…et_data_fields in storm_module.f90
Cleaned up code by re-arranging subroutines into a more logical order Added comments
Added lines to use breach_module.f90 if breaching is desired
…re outside the boundaries
@cjeffr could you remove the extra files that only have a whitespace changes? While I generally am fine with removing whitespace it looks like a bunch of files have been touched that are not related to the PR. |
Yeah that was weird, I have fixed it. |
They don't need to be in the calling sequence since setaux already assumes they are in topo_module. Some integers were implicitly declared as (kind=4) whereas recent changes to topo_module.f90 in e8afd6b declared them as (kind=8) to deal with larger topo files.
In some tests this leads to fewer ntogo errors (too many dt reductions)
…rcle also kmltools.transect2kml to make a kml file displaying them. Sample usage for transect from Tohoku to Crescent City: xtrans,ytrans = util.gctransect(142,37,-124.2,41.74,50,'W') kmltools.transect2kml(xtrans,ytrans)
Fix a bug introduced when converting from int*4 to int*8.
…notebook into the isaac_data_derived example and updated the isaac.PRE and isaac.WIN in the scratch directory ;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add functionality to use data storm products such as Oceanweather (OWI) wind and pressure files for storm simulations. Example case will be sent separately as the current example is using proprietary data that can't be shared publicly.