Fix some minor issues and warnings in the Meson build config #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tends to not work well in situations where `python3` is an executable that doesn't match the Python interpreter we are building for. Happens in particular in distro setups with multiple Python versions installed under /usr/bin/.
A ton of these are visible at least on macOS: ``` ld: warning: could not create compact unwind for ___workspace_MOD_alloc_workspace: registers 27 and 28 not saved contiguously in frame ld: warning: could not create compact unwind for _flux1_: registers 72 and 73 not saved contiguously in frame ``` The alternative solution may be to add `-fno-omit-frame-pointer`, see https://onexception.dev/news/1123392/xcode-15-upgrade-warnings-with-react-native-v0-72-4-on-m1-mac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by gh-249. I can't reproduce that issue, but this PR should at least help make such issues easier to diagnose. Changes:
python3, because that may not work on Windows or whenpython3is not the interpreter that clawpack is being built for--quietto thef2pycalls to remove a lot of noise in the build logs (not 100% quiet, look like something needs fixing in f2py as well)-Wl,-no_compact_unwindto avoid a lot more build warnings (see the commit message for details)f2pyversion number to the build log (helps diagnose build-related bug reports)