Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer requirements file. #240

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

ketch
Copy link
Member

@ketch ketch commented Nov 12, 2023

As suggested here: #238 (comment) This will install meson-python and ninja which are needed for editable installs, as well as spin and pytest, which are useful for developers.

I also updated to point to the latest versions of each sub-module, as suggested in #238.

As suggested here: clawpack#238 (comment)
This will install meson-python and ninja which are needed for editable installs,
as well as spin and pytest, which are useful for developers.
@dalcinl
Copy link

dalcinl commented Nov 12, 2023

Please add ninja as well, otherwise things will fail if ninja is not installed

@ketch
Copy link
Member Author

ketch commented Nov 12, 2023

Good catch -- I did now.

@ketch
Copy link
Member Author

ketch commented Feb 17, 2024

I'm going to go ahead and merge this since there haven't been any objections, and the issue of needing to install meson first keeps tripping people up.

@rjleveque we still need to modify the installation instructions to tell people to use this; i.e.

pip install -r requirements-dev.txt
pip install --user --no-build-isolation -e .

@rjleveque
Copy link
Member

@ketch: Sounds good, I will update the docs shortly.

@rjleveque
Copy link
Member

Documentation now updated, https://www.clawpack.org/developers.html

@rjleveque rjleveque merged commit fce2c28 into clawpack:master Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants