Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#228: implement a filesystem harvester #229

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#228: implement a filesystem harvester #229

wants to merge 2 commits into from

Conversation

etj
Copy link
Contributor

@etj etj commented Sep 19, 2019 •
edited

PR for #228

@etj
Copy link
Contributor Author

etj commented Oct 1, 2019

@amercader do you think this harvester can be useful to the community? I would close the PR otherwise.

@amercader
Copy link
Member

I think it might be useful so happy to get it in. But I think it should have at least some basic tests. Can you have a look at test_harvest.py and see if they are easy to replicate for your case? (Yes, I know that the Travis build is broken, we need to look into that 😞 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etj @amercader