Adding validator and parser for default_groups and tags config #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to update tests to support this change if there is some desire to have it contributed back in to core :) |
|
@ebuckley this looks great, it would be great if you could update the tests (and test this new behaviour) thanks |
- Work done by Tobias Schulmann <tobiasschulmann@catalyst.net.nz>
- Adding the validation that is done in ckanext-harvestor to here for consistencey
- originally done Wed Dec 14 09:46:10 2016 +1300
- the envelope query would have values above 180, which is not valid CQL
ebuckley
force-pushed
the
ckan-2.7-support-spatial
branch
from
03fec0d
to
5315a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ckan NZ is running a fork of ckanext-spatial which includes a few extra validation steps and a few modifications that make source config closer to the base ckan harvester behaviour.
Changes