Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

145 maximum dataset max limitation that a showcase can hold #147

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

145 maximum dataset max limitation that a showcase can hold #147

wants to merge 6 commits into from

Conversation

bellisk
Copy link
Contributor

@bellisk bellisk commented Aug 10, 2022

Todo:

  • add config option for number of datasets on a showcase per page
  • adjust templates: showcase read and showcase manage
  • return total in output of ckanext_package_showcase_list API call

@bellisk bellisk linked an issue Aug 10, 2022 that may be closed by this pull request
Maximum dataset max limitation that a showcase can hold #145
Open
@bellisk bellisk force-pushed the 145-maximum-dataset-max-limitation-that-a-showcase-can-hold branch 2 times, most recently from c52ba09 to 4bc9ef0 Compare August 15, 2022 08:58
@bellisk
Use fq for dataset search, not q
8414432 
The Solr maxBooleanClauses config only applies to terms in a query string, not a filter query: https://solr.apache.org/guide/8_1/query-settings-in-solrconfig.html#maxbooleanclauses

This will prevent Solr crashing when a showcase has >1024 datasets associated with it.

When searching for datasets that are *not* associated wtih a showcase, we already use an equivalent query in the fq parameter: https://github.com/ckan/ckanext-showcase/blob/master/ckanext/showcase/utils.py#L313.
@bellisk
Paginate list of packages associated with a showcase
64e0603
@bellisk
Add action to get number of datasets in a showcase
ea70bec 
Necessary because the action ckanext_showcase_package_list now returns a paginated result
@bellisk
Convert value from config to int before using
7bc82f6
@bellisk
WIP: display showcase datasets paginated on manage-datasets page
edeed5e
@bellisk bellisk force-pushed the 145-maximum-dataset-max-limitation-that-a-showcase-can-hold branch from 4bc9ef0 to edeed5e Compare August 15, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maximum dataset max limitation that a showcase can hold
1 participant
@bellisk