Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty multiple_checkbox #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frafra
Copy link

@frafra frafra commented Sep 24, 2023

Fix #387.

I am not even sure if the "required" check code if ever run, since the validator is not executed when the field is missing when handling package_patch:

if field.get('required') and not selected:
errors[key].append(_('Select at least one'))

Therefore, I guess this patch should also fix this issue as well, since the validator should always be triggered. I have not tested it, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty multiple_checkbox is not saved
1 participant