-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace usage of unicode with unicode_safe #299
base: master
Are you sure you want to change the base?
Conversation
hey @wardi what's your opinion over this? |
There is a number of places that can be changed as well(even though they do not affect the logic and can be ignored): |
@smotornyuk thanks for your suggestion and can you please clarify what you mean by Thanks |
hey @smotornyuk does my latest commit seems ok ? |
If you just drop it, it's ok for new schemas. But every person who is using But, if you want to hide this change (I'll explain, why you may choose this option) and to make your PR compatible with existing schemas(i.e,
Except for backward compatibility - yes. But you've introduced one issue. the
with something like
|
I'd be happy to add a copy of |
Hey Ian, is there anything else that can be done on this PR? |
Hi everyone. May I ask, what's gonna happen with this? I am trying to migrate to 2.10 and am experiencing some trouble with this. I guess once more ppl migrate, more will be affected? There are no more logs for the failed tests so I am not sure what the issue is. If it's something I can help fix, I'm up for it! |
I don't see a way to re-run tests from the web UI, @TomeCirun if you want to merge again we should be able to see the reason for the test failures, or @ChristianF88 if you like you could create another PR based on this branch |
Hi @TomeCirun, I'm not sure how to interpret the thumbs up. Are you gonna merge again? Cheers |
Fix #298