Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags needs its own form_snippet to fix css class #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

howff
Copy link
Contributor

@howff howff commented Nov 20, 2019

CSS includes form-control which causes incorrect layout.
In order to remove form-control we need a new form_snippet for tags; same as for text but without form-control.
Fixes #219
except only for tags not file format or other glitches.

@LukeTully
Copy link
Contributor

@howff Did you find why this was? Is form-control used as the selector for the tag_string_autocomplete preset javascript? Seems like adding a class called "NOT-form-control" could be approached differently if we know what specifically is causing the issue.

@howff
Copy link
Contributor Author

howff commented Dec 19, 2019

I didn't try too hard to find the exact cause, sorry it was a quick hack to get it working. I left the CSS in there and added the NOT prefix just to indicate where the fault lies, not because I want a class with that name. The effect seemed to be caused by the class appearing twice, once on an element which is underneath the element we want, and having the class applied to the top one caused it to be offset from the one underneath instead of hiding it.

Conzar added a commit to manaakiwhenua/ckanext-scheming that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

form-control class creates two inputs fields, one above the other
2 participants