Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form-control class creates two inputs fields, one above the other #219

Closed
frafra opened this issue Nov 6, 2019 · 8 comments · May be fixed by #225
Closed

form-control class creates two inputs fields, one above the other #219

frafra opened this issue Nov 6, 2019 · 8 comments · May be fixed by #225

Comments

@frafra
Copy link

frafra commented Nov 6, 2019

Removing form-control fixes the issue:

{"class": "form-control"}, **field.get('form_select_attrs', {}))) }}>

Screenshot_2019-11-06 Datasets - COAT Data Portal

@frafra
Copy link
Author

frafra commented Nov 12, 2019

Same glitch happens for file format.

@howff
Copy link
Contributor

howff commented Nov 20, 2019

Are you sure it's multiple_select.html which renders the tags(keywords) in your screenshot?
I see the same problem when using tags but multiple_select.html is not used, text.html is used.
However editing text.html to remove form-control affects all normal text entry fields.
The solution seems to be adding a new form_snippet, say tags.html, which is a copy of text.html but without the form-control class, and referencing this form_snippet in the preset.

(No comment on the file format issue, I've not tried it yet)

@frafra
Copy link
Author

frafra commented Nov 21, 2019

I found this problem in tags first, but I had to fix it on text.html too.

@bstutsky
Copy link

This also seems to be an issue for resource_format_autocomplete

@LukeTully
Copy link
Contributor

@frafra What did your schema look like for this? Did you resolve the issue?

@frafra
Copy link
Author

frafra commented Dec 23, 2019

@LukeTully I just removed the class from the template manually as workaround.

@Patrick1Rhode
Copy link

Note guys, we also have experienced this issue.

image_2021_04_16T16_08_44_961Z

We have solved this and other problems by adding a custom CSS.

.form-control {
padding: unset;
}

.control-full input, .control-full select, .control-full textarea {
height: 34px;
}

.select2-container{
height:auto;
}

Can we evaluate this CSS in the core?

ccancellieri added a commit to ccancellieri/ckanext-scheming that referenced this issue Apr 16, 2021
This should address:
ckan#219

Since Select2 comes from the core, I'm wondering if we would like to port the .select2-container class fix to the core instead of patching it here...

Note that I'm intentionally not abusing !important usage, it's not necessary
@frafra
Copy link
Author

frafra commented Nov 22, 2021

This bug has been fixed.

@frafra frafra closed this as completed Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants