Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 3 upgrade #89

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

JonasHillerDkd
Copy link

Edit the template files for the bootstrap 3 compatibility.

@amercader
Copy link
Member

That's great @JonasHillerDkd ! One thing that will happen though is that the templates won't render properly for those users using Bootstrap 2. Given than most changes are class renames perhaps a simple approach would be to add both bootstrap 2 and 3 class names, as each version will ignore the other one's. Happy to consider other approaches too

@JonasHillerDkd
Copy link
Author

Hello amercader,

actually you are right with this:

Given than most changes are class renames perhaps a simple approach would be to add both bootstrap 2 and 3 class names, as each version will ignore the other one's.

But i added a new css class and edited the template file base_form.html. I guess that the template editing will not be compatible with Bootstrap 2.

Kind regards
Jonas

Minh-Thien Nhan and others added 6 commits April 22, 2020 12:13
This fixes situations where some IUploader implementations may return an absolute HTTP URL as the `image_url` after uploading. This changes the logic to only prefix URLs with the static URL if they are not already absolute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants