Limit Sysadmin Updating (no self modify, no system user modify) #8155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added extra validator to updating a user's sysadmin value.
- Added change log file. - Minor fix to new test.
- Flake8 syntax fixes.
- Pyrigth fixes.
- Fixed logic in new validator.
- Using ignore_auth with fake user should be allowed.
- Using ignore_auth with fake user should be allowed. - Better logic for no value provided.
- Return values for new validator.
|
Wow okay, finally got all the tests working. |
amercader
reviewed
Apr 10, 2024
Co-authored-by: Adrià Mercader <amercadero@gmail.com>
- More test coverage. - Updated some logic and errors.
- flake8 fixes.
|
ooohh @amercader I am suddenly recalling another reason why I did the So should I check the ignore_auth thing still if the provided user does not exist in the DB? Or is there a better way to do that? |
- Use site id instead of loopback.
|
@amercader I tried changing the |
|
no worries @JVickery-TBS this is on my list to have a closer look. I'll figure out what's the best approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(validator): sysadmin update;
Proposed fixes:
Adds an extra validator to the user schema which limits the capabilities of modifying a User's sysadmin value. Limits it so you cannot modify your own sysadmin value, or the system user's sysadmin value.
Features:
Please [X] all the boxes above that apply