Catch error in datastore #8149
Open
Catch error in datastore #8149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardi
reviewed
Apr 3, 2024
ckanext/datatablesview/blueprint.py
Outdated
| } | ||
| ) | ||
| except ObjectNotFound: | ||
| return json.dumps({'error': 'Object not found'}) |
There was a problem hiding this comment.
Is this the response datatables expects on errors? Does it render the text in a dialog box or something?
Should probably also set the response status to 404.
There was a problem hiding this comment.
Should also catch NotAuthorized here
There was a problem hiding this comment.
@wardi This function is a response for a POST and only returns JSON with no status (even for errors).
https://github.com/ckan/ckan/blob/master/ckanext/datatablesview/blueprint.py#L141
I just add statu codes for all responses
There was a problem hiding this comment.
Should also catch NotAuthorized here
Added here avdata99@ff1b9d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch an error in datastore to avoid 500 error in POSTs to
datatables/ajax/<resource_view_id>The
datastore_searchaction raises this error, it's captured later in this function but not hereFeatures:
Please [X] all the boxes above that apply