Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten validation for id fields (followup) #8069

Merged
merged 40 commits into from
May 23, 2024
Merged

Tighten validation for id fields (followup) #8069

merged 40 commits into from
May 23, 2024

Commits on Oct 19, 2023

  1. Add validation and test to Resource

    @shashigharti
    shashigharti committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    0ff9e93 View commit details
    Browse the repository at this point in the history

  2. Fix for failing test

    @shashigharti
    shashigharti committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    482b796 View commit details
    Browse the repository at this point in the history

  3. Rename resource_id_validator function to id_validator

    @shashigharti
    shashigharti committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    19937f0 View commit details
    Browse the repository at this point in the history

  4. Add validation for Resource View

    @shashigharti
    shashigharti committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    7669403 View commit details
    Browse the repository at this point in the history

  5. Add validator to check unique id value

    @shashigharti
    shashigharti committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    df1e66f View commit details
    Browse the repository at this point in the history

  6. Add validation to group

    @shashigharti
    shashigharti committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    fd771ce View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. change test name

    @shashigharti
    shashigharti committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    1b580c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Added validation for package extra

    @shashigharti
    shashigharti committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3308546 View commit details
    Browse the repository at this point in the history

  2. Added id validation for group extras

    @shashigharti
    shashigharti committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    7d6c4de View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Add validation in tag

    @shashigharti
    shashigharti committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f08e4d8 View commit details
    Browse the repository at this point in the history

  2. Add id validator for activity

    @shashigharti
    shashigharti committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    946a07d View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge branch '7604/tighten-validation-for-id-fields' of https://githu… 

    …b.com/shashigharti/ckan into shashigharti-7604/tighten-validation-for-id-fields
    @amercader
    amercader committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    a230be1 View commit details
    Browse the repository at this point in the history

  2. Add id_validator to datasets

    @amercader
    amercader committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4f85b61 View commit details
    Browse the repository at this point in the history

  3. Tag ids can not be set by users

    @amercader
    amercader committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0c9daaa View commit details
    Browse the repository at this point in the history

  4. Activity ids can not be set via the API

    @amercader
    amercader committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    dcf84e8 View commit details
    Browse the repository at this point in the history

  5. Consolidate order of the validators

    @amercader
    amercader committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    393e17f View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Separate validator for user id

    @amercader
    amercader committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e3d6200 View commit details
    Browse the repository at this point in the history

  2. Separate schema for extras show

    @amercader
    amercader committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    0ed63cc View commit details
    Browse the repository at this point in the history

  3. Better message for id validator

    @amercader
    amercader committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    bb8e533 View commit details
    Browse the repository at this point in the history

  4. Prevent further validation on empty_if_not_sysadmin

    @amercader
    amercader committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    9fbd0b9 View commit details
    Browse the repository at this point in the history

  5. No id validation on group show

    @amercader
    amercader committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    18c19f5 View commit details
    Browse the repository at this point in the history

  6. User id or name when updating

    @amercader
    amercader committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    09c00c9 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Fix validators for resource update

    @amercader
    amercader committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    6af7cd0 View commit details
    Browse the repository at this point in the history

  2. Fix id length in test

    @amercader
    amercader committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    ea1d824 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Enforce actual UUIDs as ids

    @amercader
    amercader committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    c48bc71 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Fix more uuid tests

    @amercader
    amercader committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    22e4cb5 View commit details
    Browse the repository at this point in the history

  2. Simplify schema methods in IGroupForm 

    Following the pattern in the IDatasetForm, consolidate all schemas
around three variants:

* `create_group_schema` (base)
* `update_group_schema`
* `show_group_schema`

All of them with defaults in `ckan/logic/schema.py`. The old methods
have been kept for backwards compatibility.
    @amercader
    amercader committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    8922684 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Fix more uuid tests

    @amercader
    amercader committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    24da1f1 View commit details
    Browse the repository at this point in the history

  2. Fix schema for user form

    @amercader
    amercader committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    3eca61b View commit details
    Browse the repository at this point in the history

  3. Remove empty_if_not_sysadmin from resource ids 

    Because we can not use different schemas for resources for update and
create, this validators prevents resource updates for normal users.
    @amercader
    amercader committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5868a7b View commit details
    Browse the repository at this point in the history

  4. Lint

    @amercader
    amercader committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    920a8df View commit details
    Browse the repository at this point in the history

  5. Add changelog

    @amercader
    amercader committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    dc6bbad View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge branch 'master' into shashigharti-7604/tighten-validation-for-i… 

    …d-fields
    @amercader
    amercader committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d9968bb View commit details
    Browse the repository at this point in the history

  2. Re-add schema calls lost during last merge

    @amercader
    amercader committed May 14, 2024
    Configuration menu
    Copy the full SHA
    48cde8e View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Add schema methods to IGroupForm

    @amercader
    amercader committed May 15, 2024
    Configuration menu
    Copy the full SHA
    0c7daf9 View commit details
    Browse the repository at this point in the history

  2. lint

    @amercader
    amercader committed May 15, 2024
    Configuration menu
    Copy the full SHA
    3758551 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Changelog tweaks

    @amercader
    amercader committed May 17, 2024
    Configuration menu
    Copy the full SHA
    a7e16b1 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Fall back to old IGroupForm methods for compatibility

    @amercader
    amercader committed May 21, 2024
    Configuration menu
    Copy the full SHA
    bd720fd View commit details
    Browse the repository at this point in the history

  2. lint

    @amercader
    amercader committed May 21, 2024
    Configuration menu
    Copy the full SHA
    517a8ee View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Better plugin schema methods checks

    @amercader
    amercader committed May 22, 2024
    Configuration menu
    Copy the full SHA
    dbbf0fa View commit details
    Browse the repository at this point in the history