More Flash Messages

changes/7996.feature

@@ -0,0 +1 @@
+Adds more flash messages to Group views. Adds flash message to User API token revoke.

ckan/views/group.py

@@ -929,6 +929,15 @@ def post(
 
         try:
             get_action(action_functions[action])(context, data_dict)
+            if action == 'private':
+                h.flash_notice(_('Made %s dataset(s) private.')
+                               % len(datasets))
+            elif action == 'public':
+                h.flash_notice(_('Made %s dataset(s) public.')
+                               % len(datasets))
+            elif action == 'delete':
+                h.flash_notice(_('Deleted %s dataset(s).')
+                               % len(datasets))
         except NotAuthorized:
             base.abort(403, _(u'Not authorized to perform bulk update'))
         return h.redirect_to(u'{}.bulk_process'.format(group_type), id=id)
@@ -977,6 +986,10 @@ def post(self, group_type: str,
         data_dict['users'] = [{u'name': user, u'capacity': u'admin'}]
         try:
             group = _action(u'group_create')(context, data_dict)
+            if is_organization:
+                h.flash_success(_('Organization created.'))
+            else:
+                h.flash_success(_('Group created.'))
         except (NotFound, NotAuthorized):
             base.abort(404, _(u'Group not found'))
         except ValidationError as e:
@@ -1075,6 +1088,10 @@ def post(self,
             group = _action(u'group_update')(context, data_dict)
             if id != group['name']:
                 _force_reindex(group)
+            if is_organization:
+                h.flash_success(_('Organization updated.'))
+            else:
+                h.flash_success(_('Group updated.'))
         except (NotFound, NotAuthorized):
             base.abort(404, _(u'Group not found'))
         except ValidationError as e:
@@ -1229,6 +1246,11 @@ def post(self,
 
         try:
             group_dict = _action(u'group_member_create')(context, data_dict)
+            messages = {'member': _('Assigned %s as a member.'),
+                        'editor': _('Assigned %s as an editor.'),
+                        'admin': _('Assigned %s as an admin.')}
+            h.flash_success(messages[data_dict['role']]
+                            % data_dict['username'])
         except NotAuthorized:
             base.abort(403, _(u'Unauthorized to add member to group %s') % u'')
         except NotFound:

ckan/views/resource.py

@@ -682,11 +682,14 @@ def post(self,
             if to_delete:
                 data[u'id'] = view_id
                 get_action(u'resource_view_delete')(context, data)
+                h.flash_notice(_('View deleted.'))
             elif view_id:
                 data[u'id'] = view_id
                 data = get_action(u'resource_view_update')(context, data)
+                h.flash_success(_('View updated.'))
             else:
                 data = get_action(u'resource_view_create')(context, data)
+                h.flash_success(_('View created.'))
         except ValidationError as e:
             # Could break preview if validation error
             to_preview = False

ckan/views/user.py

@@ -282,7 +282,9 @@ def post(self, id: str) -> Union[Response, str]:
 
 def api_token_revoke(id: str, jti: str) -> Response:
     try:
+        token = model.ApiToken.get(jti)
         logic.get_action(u'api_token_revoke')({}, {u'jti': jti})
+        h.flash_notice(_('Deleted API token %s') % token.name if token else '')
     except logic.NotAuthorized:
         base.abort(403, _(u'Unauthorized to revoke API tokens.'))
     return h.redirect_to(u'user.api_tokens', id=id)