Fix Wrong facet function called when defining a custom group #7654 #7994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Labuschagne-Miro BTW This PR is not copied, In the last PR Tests are failing Thanks for your understanding. |
|
@Vishal-NEC I have commented on pull request #7754 before you have raise this pull request. You should first confirm with author and community member before working on any issue. Secondly, All test cases are passing doesn't mean your pull request is complete enough to fix the issue. |
|
@Zharktas , What is your opinion on this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Wrong facet function called when defining a custom group is fixed in this PR.
#7654