Tighten validation for id fields #7868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amercader
reviewed
Oct 19, 2023
ckan/logic/validators.py
Outdated
Comment on lines
241
to
243
| entities_map = { | ||
| 'resource_view': model.ResourceView, | ||
| 'group': model.Group |
There was a problem hiding this comment.
@shashigharti I think in this case it's safer to have individual validators for each entity type even if that means many different functions. Relying on the keys to determine the entity type won't always be safe. And it will make overriding specific validators easier for plugins.
So let's go for resource_view_id_does_not_exist, group_id_does_not_exist, etc
shashigharti
changed the title
shashigharti
force-pushed
the
7604/tighten-validation-for-id-fields
branch
from
6bd95eb
to
946a07d
Compare
|
Closed in favour of #8069 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7604
Proposed fixes:
Features:
Please [X] all the boxes above that apply