Skip to content

Commit

Permalink
Don't use Resource factories when creating new Datasets
Browse files Browse the repository at this point in the history
The Resource factory creates an actual Resource model linked to an
automatically created dataset. If trying to create a Dataset factory
passing a resource one, it will fail as the id already exists
  • Loading branch information
amercader committed May 24, 2023
1 parent 8bd1191 commit 7179cda
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions ckan/tests/logic/auth/test_delete.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def test_no_org_user_cant_delete(self):
user = factories.User()
org = factories.Organization()
dataset = factories.Dataset(
owner_org=org["id"], resources=[factories.Resource()]
owner_org=org["id"], resources=[{"url": "https://example.com/data.csv"}]
)

response = auth_delete.resource_delete(
Expand All @@ -66,7 +66,7 @@ def test_org_user_can_delete(self):
org_users = [{"name": user["name"], "capacity": "editor"}]
org = factories.Organization(users=org_users)
dataset = factories.Dataset(
owner_org=org["id"], resources=[factories.Resource()], user=user
owner_org=org["id"], resources=[{"url": "https://example.com/data.csv"}], user=user
)

response = auth_delete.resource_delete(
Expand All @@ -92,7 +92,7 @@ def test_no_org_user_cant_delete_2(self):
user = factories.User()
org = factories.Organization()
dataset = factories.Dataset(
owner_org=org["id"], resources=[factories.Resource()]
owner_org=org["id"], resources=[{"url": "https://example.com/data.csv"}]
)

resource_view = factories.ResourceView(
Expand All @@ -113,7 +113,7 @@ def test_org_user_can_delete_2(self):
org_users = [{"name": user["name"], "capacity": "editor"}]
org = factories.Organization(users=org_users)
dataset = factories.Dataset(
owner_org=org["id"], resources=[factories.Resource()], user=user
owner_org=org["id"], resources=[{"url": "https://example.com/data.csv"}], user=user
)

resource_view = factories.ResourceView(
Expand Down

0 comments on commit 7179cda

Please sign in to comment.