VMStorageOCI: percent-encode the colon in RemoteName's host

[edigaryev]

Resolves #827.

[fkorotkov]

Should we just ignore port for storing OCI images? Don't think anyone will ever have two registries on different ports. 🤔

[edigaryev]

Should we just ignore port for storing OCI images? Don't think anyone will ever have two registries on different ports. 🤔

IMO we should not assume anything about things that are security-related. It's hard to say exactly what registry configurations people could be using.

[fkorotkov]

I just don't like String extensions that are used at specific location. This is an edge case for hosts and preferably this logic should be isolated. For example, I'll need time to understand why this line is changed and think if we covered all the places. There is a feeling this host specific logic should be better scoped.

[edigaryev]

I just don't like String extensions that are used at specific location.

Switched to an ordinary funcions in 0919606 and added a comment explaining this:

tart/Sources/tart/VMStorageOCI.swift

Line 116 in 7c386e3

let parts = [foundURL.deletingLastPathComponent().relativePath, foundURL.lastPathComponent]