Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update env var (holder) for images based on Server version #8770

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

kelvintaywl
Copy link
Member

@kelvintaywl kelvintaywl commented May 17, 2024

Description

I changed the SERVER_4_x_IMAGE_LIST env var used in our example scripts to reflect the Server 4.x version correctly.

Reasons

Server 4.1 and 4.2 were consistent;
From Server 4.3 onwards, this wasn't changed. Hence, this PR to clean up for clarity.

Content Checklist

Please follow our style when contributing to CircleCI docs. Our style guide is here: https://circleci.com/docs/style/style-guide-overview.

Please take a moment to check through the following items when submitting your PR (this is just a guide so will not be relevant for all PRs) 馃樃:

  • Break up walls of text by adding paragraph breaks.
  • Consider if the content could benefit from more structure, such as lists or tables, to make it easier to consume.
  • Keep the title between 20 and 70 characters.
  • Consider whether the content would benefit from more subsections (h2-h6 headings) to make it easier to consume.
  • Check all headings h1-h6 are in sentence case (only first letter is capitalized).
  • Is there a "Next steps" section at the end of the page giving the reader a clear path to what to read next?
  • Include relevant backlinks to other CircleCI docs/pages.

@kelvintaywl kelvintaywl requested review from a team as code owners May 17, 2024 02:20
@rosieyohannan rosieyohannan merged commit 59b0236 into master Jun 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants