-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add user manual how to enable and configure multicast feature. #32612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fujitatomoya!
I left several style suggestions, but the main request is to add "(Beta)" to the page header.
We should also add the new doc to the CODEOWNERS file. I guess sig-datapath would be a good codeowner, is that right @ldelossa? Then the CODEOWNERS file should include:
/Documentation/network/multicast.rst @cilium/sig-datapath @cilium/docs-structure
(the entries are listed alphabetically). Can you add it @fujitatomoya?
33c571b
to
8f8007c
Compare
@lambdanis all comments are addressed, and rebasing is done. ready to 2nd review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more request, otherwise looks good, thanks @fujitatomoya!
Could you also squash the commits into one?
975822a
to
12286bb
Compare
@lambdanis thanks, addressed prerequisites header and squash all commits into one. |
12286bb
to
7d1f40e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CODEOWNERS lgtm
/test |
@lambdanis yes your suggestion about codeowner looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some wording issues, but overall looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit change, otherwise looks good to me.
7d1f40e
to
01c22d3
Compare
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
01c22d3
to
5e5403c
Compare
/test |
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #28750
related references: