[WIP] Settings model with both pydantic 1 and 2 support #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage ? 92.18%
=======================================
Files ? 7
Lines ? 422
Branches ? 0
=======================================
Hits ? 389
Misses ? 33
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Comment on lines
+10
to
+14
| # Support for both pydantic 1 and 2 | ||
| try: | ||
| from pydantic.v1 import root_validator | ||
| except ImportError: | ||
| from pydantic import root_validator |
There was a problem hiding this comment.
I think this is what we're doing too everywhere. If we wanted to migrate to v2 only, we'd have to chase upstream to check if anything is v1 only. I haven't had time to check, but I'd guess that OpenFF + QCStack might be a place where there's significant usage of pydantic (and I have no idea if they've prioritised this).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydantic 2 changed a significant amount of things in the validators. A quick (and dirty?) way of supporting both is using
pydantic.v1import and catching anImportErrorexception.This is still a work in progress and maybe we might consider just sticking with pydantic 1 for now.