Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogNormalWrapper improvements #93

Merged
merged 3 commits into from
Apr 29, 2017
Merged

LogNormalWrapper improvements #93

merged 3 commits into from
Apr 29, 2017

Conversation

jchodera
Copy link
Member

@jchodera jchodera commented Apr 27, 2017 •
edited

This PR makes several small improvements after the introduction of LogNormalWrapper in #83

  • Bugfix for LogNoramlWrapper typo
  • Use a Taylor expansion to overcome precision limitations when (stddev/mean)**2 is small

Fixes #92

@jchodera jchodera mentioned this pull request Apr 27, 2017
Closed
@jchodera jchodera changed the title [WIP] Bugfix and error checking LogNormalWrapper improvements Apr 28, 2017
@jchodera
Copy link
Member Author

This should be ready to merge if tests pass.

@jchodera
Copy link
Member Author

Seems to work.

delg_dansylamide-dg-2017-04-28 1845

@MehtapIsik
Copy link
Contributor

I run another example and there wasn't any problem. I am merging this pull request.

@MehtapIsik MehtapIsik merged commit 9836622 into master Apr 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonyahanson sonyahanson Awaiting requested review from sonyahanson

@MehtapIsik MehtapIsik Awaiting requested review from MehtapIsik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown error/warning with Quickmodel
2 participants
@jchodera @MehtapIsik