Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce v1.5 compatibility #1621

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mfrancis95
Copy link
Contributor

Probably the most pointless version "emulation" you'll ever see. Based on https://doomwiki.org/wiki/Versions_of_Doom_and_Doom_II#v1.5:

  • Introduced a new exe_doom_1_5 game version.
  • "Factored in mobj radius in P_CheckMeleeRange" - used exe_doom_1_5 as a comparison point instead of exe_doom_1_2.
  • "Replaced short-range hitscan by melee range check in A_SargAttack" - same as the above.
  • "Monster barrel suicides are no longer possible" - same as the above.

So in reality, not much was actually changed and this is mostly semantics, but this is to also help pave the way for inserting 1.4 compatibility in between which has its own changes distinct from 1.2 and 1.5.

To Do:

  • Figure out what the demo identifier for 1.5 is and auto-detect it so the -gameversion doesn't always need to be explicitly passed.
  • Find out what "Deathmatch bug fixed where items reappeared but could not be picked up" is about and see if this can be addressed or matched up to this new version in the code.

Copy link
Member

@turol turol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable but I have not actually tested any of it.

@mfrancis95 mfrancis95 marked this pull request as draft October 18, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants