Disable -fast for gameversion 1.2 #1550
Conversation
The first appearance of the "-fast" string in DOOM.EXE is in the v1.4 beta leak (1994-04-08). Vanilla v1.2 ignores the "-fast" switch.
|
Well the code looks ok but should there be a warning if the user has specified both version 1.2 and fast monsters? Silently ignoring parameters makes for confused users. |
|
I think such a warning might be appropriate in Crispy but not in Choco. For one, vanilla silently ignored most of invalid parameters or combinations thereof; for another, if we decide to provide a warning for this case what about a myriad of other such cases? E.g. -wad foobar.wad There would be no end in sight. |
|
I'm in favor of warning in all cases where unexpected command line parameters or interactions occur. But this is more of a project philosophy question. @fragglet Thoughts? |
| // -fast was not an option until Doom v1.4 | ||
| if (gameversion <= exe_doom_1_2) | ||
| { | ||
| fastparm = 0; |
There was a problem hiding this comment.
I am also in favor of a warning message printed to stdout here. Sure, Vanilla Doom didn't write a lot. But Vanilla Doom didn't try to emulate the behaviour of previous releases of itself either. And I find it confusing enough if a parameter does work for one emulated version of Doom but not for the other, so a hint for the concerned user is very much justified.
The first appearance of the "-fast" string in DOOM.EXE is in the v1.4 beta leak (1994-04-08). Vanilla v1.2 ignores the "-fast" switch.