Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show ENDOOM screen in the same window as the game #1331

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

fabiangreffrath
Copy link
Member

This may not be the most beautiful implementation, but this is
what I have come up with after an hour of free time today.

Open for discussion and suggestions.

This may not be the most beautiful implementation, but this is
what I have come up with after an hour of free time today.

Open for discussion and suggestions.
@drfrag666
Copy link
Contributor

I've tested this and in fullscreen mode the text screen is small and centered (surrounded by a black area). In windowed mode if the window is smaller part of it is cut outside. Is there any way to scale it?

@drfrag666
Copy link
Contributor

Now that i think of it the startup console also it's in a different window and closes when you close the game so then i'd need to recreate it using the library to integrate it in the game window too.

@fabiangreffrath
Copy link
Member Author

The ENDOOM content is smaller than the rendered game content, just like in the original implementation where the ENDOOM window is smaller than the actual game window. The is no scaling applied yet, as I have tried to keep this initial PR as small as possible and let is serve as a base for improvement.

@drfrag666
Copy link
Contributor

Of course i know. Let's see what @fragglet thinks then. I think it's a good idea as long as the content is scaled.

which result in the ENDOOM screen being rendered properly scaled and centered
Copy link
Member

@turol turol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see this rebased and split into more meaningful commits but if you don't want to I won't really require it.


TXT_Init();

TXT_SetWindowTitle(PACKAGE_STRING);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where has this been moved to?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if ENDOOM appears in the same window as the game, it won't need to set a new window title.

@fabiangreffrath
Copy link
Member Author

I would like to see this rebased and split into more meaningful commits but if you don't want to I won't really require it.

It was a series of commits in Woof!. I just copied the relevant changes here.

@fabiangreffrath
Copy link
Member Author

This reminds me, should probably check the animated intro screens for thd non-Doom games as well.

@fabiangreffrath fabiangreffrath marked this pull request as draft March 21, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants