If Nuked OPL3 is running at 49716 Hz, the emulator output isn't passe… #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d through the linear resampler when using OPL3_GenerateStream.
|
Please give some context about the purpose of this change. It looks like maybe this is supposed to make the code more efficient if the output frequency is 49716hz? If so, that seems redundant because most audio hardware will not run at that sample rate anyway. |
|
Yes, that is correct. Some projects initialize OPL3 emulation at 49716 Hz, so this fix is for these kinds of situations where internal resampling isn't needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d through the linear resampler when using OPL3_GenerateStream.