-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New icon assets #1078
base: master
Are you sure you want to change the base?
New icon assets #1078
Conversation
Thanks for raising this! Did you create these as SVGs or another vector format, and if so do you have the vector sources? I think having vector sources in the repo would be a significant technical improvement on the current icons. I like the shape of the letter; I like the improved setup wrench; I think it's good to have the colour be brown (=chocolate) but I liked the nod to the original Doom logo in the current logo with the colour gradients, so I'd be interested to see some kind of compromise on that. I'm not sure about dropping the (raster) ice cream graphic. I'm interested to see what the other maintainers think! |
@jmtd my pleasure! Yes, these assets are derived from a vector (SVG) source, however PNG assets are still the best for icons due to technical shortcomings in I could make it look more like the original doom logo by making it two tones of "chocolate" or something like that in the way the original D has two tones. My reasoning for dropping the ice cream cone was to simplify the metaphor; it is more likely to be interpreted as "ice cream doom" than "chocolate doom" with the cone in there. ;) Also, assets derived from photographs are usually not necessarily the best for icons, as they don't scale well. |
I like it! Note that there is a separate repository (https://github.com/chocolate-doom/icon) for the icon so you might want to submit a PR there first.
I think what Jon was really asking was if we could have the original SVG source as well :) But that belongs in the other repo.
Either one that works for all four games (difficult, I think), or similar icons of the same style for Heretic ('H'), Hexen ('X') and Strife ('S'). But this is "nice to have" and I don't want it to block improving the current icon. |
@fragglet ah I wasn't aware of the other repo, I can absolutely do a PR over there. Making icons for the other 3 games shouldn't be an issue either, it'd just take me some time to come up with a design that works for those (in chocolate). |
Whilst I agree that we'll need the full suite of game icons, it might make sense to iterate on the "D" for doom first, then once that's pretty much final adapt it to the other games. |
We haven't made it this far in the past 10 years with the current icon. Why should this design be a better starting point? |
Better scalability. Higher DPI / 4K screens means that OSes are asking for 512x521 icons. Something that is easier to scale and applies consistently across the range of engines would be good. I like what @snwh has done here. It could be combined with the vector spanner / wrench that appears in the #965 / #1020 |
I'm sorry I don't understand. |
Ah, sorry. So, you suggested to start over with a new icon for Doom first and then adapt it to the other games. Well, we have an icon for Doom for at least 10 years now and yet we failed to adapt it to the other games. There were attempts in the other two issues that I mentioned, but even these have not yet gained much attention. |
Let's do it there first, and come back to this (feel free to leave this one open). There are a few occurrences of the icon in this repo which will need to be fixed:
Fantastic! Let's get the initial part merged first and then we can do that next. WDYT? |
With this approach, the chocolate-setup icon will always remain bound to the Doom icon's "D". |
Hey @snwh it seems you never got around to raising a PR for this at https://github.com/chocolate-doom/icon , are you still happy to do this? |
Hello, I've been creating icons for desktop (mostly Linux) applications for years and as an occasional user of this project and I'd thought propose and icon improvement!
My makefile-fu isn't the greatest so do let me know if this is busted (I was already having difficulties getting it to build on Fedora due to lack of proper dependencies) my strengths are in icon asset creation not deployment.