-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2: Fix small hpopt bugs and add example notebook #842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this PR. There are two minor things you might consider adding to the notebook:
- Include metrics within the model (e.g.,
metric_list = [nn.metrics.RMSEMetric(), nn.metrics.MAEMetric()]
) in the notebook. - Add the ASHAScheduler to the notebook, as we use it by default.
The test fails because the filename has changed. Changing the filename of "best_params.json" to "best_config.json" in test_hyperopt_quick within tests/unit/utils/test_save_load_mol.py can fix it. |
Co-authored-by: Shih-Cheng Li <scli@mit.edu>
@hwpang here are my final comments about the notebook
|
@shihchengli Thanks for reviewing! I have updated according to your comments |
There is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I noticed a minor thing that needed to be changed in the notebook. You can remove |
The error can be solved by changing the CI configuration to run test on hpopting.ipynb exclusively with Python 3.11. |
You can do something like this, although it's not very elegant.
|
@shihchengli Thanks for the review and the suggestion! I have updated the CI accordingly |
Description
Add an example hpopt notebook. Happy to take suggestion on the notebook.
Found some small bugs related to input type and saving hpopt results while working on the notebook. Fixed those.
Example / Current workflow
n/a
Bugfix / Desired workflow
n/a
Questions
n/a
Relevant issues
n/a
Checklist