Do not merge: jsonb support #114
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of epgsql include jsonb support. Because this is just a PoC effort for now, we'll point directly to the upstream - otherwise we need to re-do the request-timeout change [1], which can only be done safely by re-evaluating the current state of the connection protocol handling and making the change as a new change. We'll tackle that work later, if the PoC pans out. The only other impact here was that epgsql does not support the req_timeout option in upstream, so I removed it from sqerl_pgsql_client too. [1] chef/epgsql-1@7712ee2 Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
marcparadise
commented
Mar 21, 2022
| @@ -22,7 +22,7 @@ | |||
| -module(sqerl_pgsql_client). | |||
|
|
|||
| -behaviour(sqerl_client). | |||
|
|
|||
| -compile(export_all). | |||
There was a problem hiding this comment.
for debugging, need to remove
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repoints us to upstream epgsql for jsonb support, and updates the library for compatibility.
Note that we have our own timeout changes in chef/epgsql-1 that will need to be merged into upstream epgsql before we can move forward with this branch; o r we need to sync chef/epgsql-1 with upstream.