Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Erlang R19 #105

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

support for Erlang R19 #105

wants to merge 18 commits into from

Conversation

eryx67
Copy link
Contributor

@eryx67 eryx67 commented Mar 21, 2017

It seems that Erlang 19 has only one (typed) declaration for records in AST

@stevendanna
Copy link
Contributor

@eryx67 Thanks for the contribution!

Our DCO policy (read about it here: https://blog.chef.io/2016/09/19/introducing-developer-certificate-of-origin/) requires that your commit has a Signed-Off-By line affirming you agree to the DCO. You can add it to your existing commit by doing something like:

git commit --amend -s --no-edit

and then force-pushing to your branch.

cc @chef/erlangers for review

@markan
Copy link
Contributor

markan commented Aug 2, 2018

I was just looking at what it would take to update us to OTP 21 and saw this PR.
@eryx67 thank you for your work and I'd like to revive this PR if possible. Very sorry about it falling through the cracks.

Currently github is marking this as unmergable because not every commit has DCO and travis is failing. While some of the commits have DCO, not all do.

What I would suggest we do is break this PR up into a couple of pieces, each rebased on master, and updated to have DCO. I'm thinking something like this would work:

  • The update to R19
  • The connection arg improvements.
  • Update to OTP 21
  • Other functionality

Thoughts? I see you are maintaining a fork, and I think if we do the commits in the above order the git histories will be reconcilable by merge cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants